Cppcheck reports "Same expression on both sides of '=='" on dpitemdata.cxx

Ivan Timofeev timofeev.i.s at gmail.com
Sun Mar 18 07:07:10 PDT 2012


Hi

On 18.03.2012 12:41, julien2412 wrote:
> Just to make notice that Cppcheck reports "Same expression on both sides of
> '=='" on sc/source/core/data/dpitemdata.cxx, line 217. Here are the lines :
...
>      216     if (mbStringInterned && r.mbStringInterned)
>      217         return mpString == mpString;<---- HERE

Wow! There definitely must be "return mpString == r.mpString". Probably 
Kohei would like to redo his performance tests...

Do you prefer to push fixes yourself? :)

Thanks!!!

Ivan


More information about the LibreOffice mailing list