[PUSHED] Re: Cppcheck reports "Same expression on both sides of '=='" on dpitemdata.cxx

[Julien Nabet]

On 18/03/2012 15:07, Ivan Timofeev wrote:
> Hi
>
> On 18.03.2012 12:41, julien2412 wrote:
>> Just to make notice that Cppcheck reports "Same expression on both 
>> sides of
>> '=='" on sc/source/core/data/dpitemdata.cxx, line 217. Here are the 
>> lines :
> ...
>>      216     if (mbStringInterned && r.mbStringInterned)
>>      217         return mpString == mpString;<---- HERE
>
> Wow! There definitely must be "return mpString == r.mpString". 
> Probably Kohei would like to redo his performance tests...
>
> Do you prefer to push fixes yourself? :)
Fix pushed and commited on master (2b24cfe22d5d29645d2d926251c29514887fe3a9)

Thank you for the review ! :-)

Julien.