[GERRIT][PATCH] gbuild conversion l10ntools module -- new patch and gerrit question

[David Ostrovsky]

On 03.05.2012 13:23, Thorsten Behrens wrote:
> David Ostrovsky wrote:
>> 5.
>> -.IF "$(OS)" == "MACOSX"&&  "$(CPU)" == "P"&&  "$(COM)" == "GCC"
>> -# There appears to be a GCC 4.0.1 optimization error causing
>> _file:good() to
>> -# report true right before the call to writeOut at
>> HelpLinker.cxx:1.12 l. 954
>> -# but out.good() to report false right at the start of writeOut at
>> -# HelpLinker.cxx:1.12 l. 537:
>> -NOOPTFILES=\
>> -        $(OBJ)$/HelpLinker.obj \
>> -        $(SLO)$/HelpLinker.obj
>> -.ENDIF
>>
>> this was dropped.
>> Do we still need it? If uncertain, please activate it.
>>
> Hi Cloph, I think that was from you? What's your current version on
> PPC?
Actually I activated it again, because my reviewer said I have to.
I attached the new patch.
Gerrit url remains the same: https://gerrit.libreoffice.org/#/c/105/.

Gerrit really rocks!
With recently activated Change Id git trigger, this is as simple as 
commit, rebase -i/squish, push - cycle ...
and a new Patch Set version in the _same_ gerrit patch request is created.
It would be even cooler, if somebody would throw their tinderboxen 
against it (refs/for/head branch)
(especially with -Werror).

One problem seen so far with gerrit, is not visibility of entered 
comments for deleted files.
To reproduce: open side by side review for deleted file, say 
l10ntools/source/help/makefile.mk 
<https://gerrit.libreoffice.org/#/c/105/5/l10ntools/source/help/makefile.mk>.
Enter some comments on random line there and save your draft. Nobody can 
see it.
Is this a gerrit bug? Workaround would be to enter comments in review 
message itself in that case.

Ciao
David

@Michal Stahl: thank you very mch for your review and solution 
suggestions for found problems!

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20120504/16e4057f/attachment.html>