[REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

[Andras Timar]

2012/5/7 Jesús Corrius <jesus at softcatala.org>:
> Hi Andras,
>
> On Sun, May 6, 2012 at 10:34 PM, Andras Timar <timar74 at gmail.com> wrote:
>>  Fortunately the tree control under Windows can receive
>> a message that does the sort, so everything can be solved with pure
>> Windows API calls.
>>
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=39bb77fd667f9d9fdaf374f3934b6eec7b7dc57a
>
> The Windows code looks OK, but there's no error control anywhere and
> that makes me shiver.

If it fails, nothing special will happen. The control will not be
sorted, that is. I don't think we should stop and rollback the
install. We ignore the return code of most of our custom actions.

Cheers,
Andras