[REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action

Andras Timar timar74 at gmail.com
Thu May 10 01:50:30 PDT 2012


2012/5/7 Jesús Corrius <jesus at softcatala.org>:
> Hi Andras,
>
>> If it fails, nothing special will happen. The control will not be
>> sorted, that is. I don't think we should stop and rollback the
>> install. We ignore the return code of most of our custom actions.
>
> The behavior of FindWindow or FindWindowEx is different if some of the
> parameters are NULL (If hwndParent is NULL, the function uses the
> desktop window as the parent window). Although I agree that it is
> highly unlikely that we do any collateral damage, a few IFs will
> ensure that the code does what we want in all cases. So I would put
> them even if we never show any error message.

OK, what about this:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=ce1ac0851fe2e975f3fb47178730b914608610cf

Thanks,
Andras


More information about the LibreOffice mailing list