About shapeexport.cxx in xmloff

julien2412 serval2412 at yahoo.fr
Thu Nov 1 02:51:53 PDT 2012


Hi,

On xmloff/source/draw/shapeexport.cxx, line 711 seems quite weird:
    704             XMLTokenEnum eDisplayToken = XML_TOKEN_INVALID;
    705             const unsigned short nDisplay = (bVisible ? 2 : 0) |
(bPrintable ? 1 : 0);
    706             switch( nDisplay )
    707             {
    708             case 0: eDisplayToken = XML_NONE; break;
    709             case 1: eDisplayToken = XML_PRINTER; break;
    710             case 2: eDisplayToken = XML_SCREEN; break;
    711             // case 3: eDisplayToken = XML_ALWAYS break; this is the
default
    712             }

Why shouldn't we uncomment case 3?
"nDisplay" could be equalled to "3" and "eDisplayToken"  is 
"XML_TOKEN_INVALID" by default

An idea?

Julien



--
View this message in context: http://nabble.documentfoundation.org/About-shapeexport-cxx-in-xmloff-tp4016286.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list