Change in core[master]: restore --enable-symbols option again -- was FYI: Cleanup of debug options

[Michael Stahl]

On 07/11/12 22:02, David Ostrovsky wrote:
> On 07.11.2012 17:16, Tor Lillqvist wrote:
>>
>>
>>     If no one has any opinion on it, I'm going to name it
>>     --enable-symbols-only.
>>
>>
>> I don't like that, as it strongly suggests that this option would
>> cause some kind of lighter, symbol/address mapping only kind of data
>> to be emitted, as opposed to full debug information. Which is doesn't,
>> at least not for all platforms. Or am I missing something?
> no, you are right, it's the same symbol information as with full debug
> information (on all platforms). The difference between the two is only
> optimization:
> 
>                            O | S | D | T
> --------------------------------------
> production-code| x | -  | -  | -
> --------------------------------------
> enable-symbols  | x | x | -  | -
> --------------------------------------
> enable-debug     | -  | x | -  | -
> --------------------------------------
> enable-dbgutil    | -  | x | x  | x
> 
> where
> O: optimization
> S:  symbols
> D: debug STL
> T: trace facility

actually --enable-debug also sets OSL_DEBUG_LEVEL (enables tracing).

also --enable-dbgutil defines DBG_UTIL which causes some extra
debugging/checking code to be enabled.

(and it used to be the case that --enable-dbgutil by itself left
optimization enabled but apparently nowadays it disables that.)

> So to reflect what these options mean exactly one should name it as follows:
> enable-symbols: --enable-symbols-and-preserve-optimization
> enable-debug: --enable-symbols-and-disable-optimization
> enable-dbgutil:
> --enable-symbols-and-disable-optimization-and-enable-debugstl-and-enable-trace-facility
> 
> Given that we don't want to rename two last options, we are trying to
> find a new (less confusing and not so long) name
> for the first one:
> --enable-symbols-and-preserve-optimization
> 
> Ideas?

hmm.. actually i don't like --enable-symbols much because "symbols"
could refer to linker symbols when what is really meant is "symbolic
debugging information".  but then again --enable-symbols has been used
for many years in this project so people are already used to it  :)

how about --enable-release-debuginfo ? --enable-product-debuginfo ?