Calc / Kerning

[Bernhard Schiffner]

Hi,

(this is my first commit here so please be patient ...)

I'am missing the kerning feature for cells showing the result of a formula. 
The attached git diff gives an idea about what I want.

It compiles for me, shows the tab "Font Position" at the right place but does 
not do the kerning.
Any idea how to proceeed?

BTW 1)
The kerning feature ("Font Position)" is available for pure text in a cell via 
clicking input line, format->charakter->font position as you can see in
libreoffice/core/sc/source/ui/src/textdlgs.src
libreoffice/core/cui/source/tabpages/chardlg.cxx (line 2978)

BTW 2)
Applying fromat->cell for a text cell resets kerning which was selected before 
by format->character.
This can be considered as a bug, solved by implementing this idea here.

BTW 3)
libreoffice/core/cui/source/dialogs/sdrcelldlg.cxx
does have a very similar dialog. Is there some overlap?

TIA!

Bernhard


diff --git a/sc/source/ui/attrdlg/attrdlg.cxx 
b/sc/source/ui/attrdlg/attrdlg.cxx
index 2e22761..87e95be 100644
--- a/sc/source/ui/attrdlg/attrdlg.cxx
+++ b/sc/source/ui/attrdlg/attrdlg.cxx
@@ -68,6 +68,8 @@ ScAttrDlg::ScAttrDlg( SfxViewFrame*     pFrameP,
     AddTabPage( TP_FONT, pFact->GetTabPageCreatorFunc( RID_SVXPAGE_CHAR_NAME 
), 0 );
     OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_CHAR_EFFECTS ), 
"GetTabPageCreatorFunc fail!");
     AddTabPage( TP_FONTEFF, pFact->GetTabPageCreatorFunc( 
RID_SVXPAGE_CHAR_EFFECTS ), 0 );
+    OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_CHAR_POSITION ), 
"GetTabPageCreatorFunc fail!");
+    AddTabPage( TP_FONTPOS, pFact->GetTabPageCreatorFunc( 
RID_SVXPAGE_CHAR_POSITION ), 0 );
     OSL_ENSURE(pFact->GetTabPageCreatorFunc( RID_SVXPAGE_ALIGNMENT ), 
"GetTabPageCreatorFunc fail!");
     AddTabPage( TP_ALIGNMENT, pFact->GetTabPageCreatorFunc( 
RID_SVXPAGE_ALIGNMENT ),    0 );
 
diff --git a/sc/source/ui/inc/attrdlg.hrc b/sc/source/ui/inc/attrdlg.hrc
index 4c36756..7dd5273 100644
--- a/sc/source/ui/inc/attrdlg.hrc
+++ b/sc/source/ui/inc/attrdlg.hrc
@@ -26,6 +26,7 @@
 #define TP_PROTECTION   6
 #define TP_FONTEFF      7
 #define TP_ASIAN        8
+#define TP_FONTPOS      9
 
 //================================================
 // Protected cell TabPage:
diff --git a/sc/source/ui/src/attrdlg.src b/sc/source/ui/src/attrdlg.src
index a96bad9..da87300 100644
--- a/sc/source/ui/src/attrdlg.src
+++ b/sc/source/ui/src/attrdlg.src
@@ -65,6 +65,12 @@ TabDialog RID_SCDLG_ATTR
             };
             PageItem
             {
+                Identifier = TP_FONTPOS ;
+                PageResID = 264 ;
+                Text [ en-US ] = "Font Position";
+            };
+            PageItem
+            {
                 Identifier = TP_ALIGNMENT ;
                 PageResID = 258 ;
                 Text [ en-US ] = "Alignment" ;