[PATCH] API CHANGE: com.sun.star.lang.IllegalArgumentException

Michael Stahl (via Code Review) gerrit at gerrit.libreoffice.org
Tue Nov 20 10:35:31 PST 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/1145

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/45/1145/1

API CHANGE: com.sun.star.lang.IllegalArgumentException

... derives from com.sun.star.uno.RuntimeException instead of
com.sun.star.uno.Exception.

Only test that breaks with this change is jurt_uno/AnyConverter_Test,
which for mysterious reasons effectively tests that
IllegalArgumentException is a subclass of Exception and not
RuntimeException.  Presumably this is just a generic exception test that
happens to use IllegalArgumentException.

Some further testing indicates there are no problems expected at
runtime:
Running "make subsequentcheck" with all Java test code compiled against
a ridl.jar that does not contain the change, running against a soffice
that uses ridl.jar and rdbs with the change + ridl.jar with the change
on the test side yields exactly the same AnyConverter_Test failure, with
no other failures.

Change-Id: Iad183de76ec7e0d56648084e97cdcc160b5b033d
---
M dbaccess/source/ui/uno/copytablewizard.cxx
M desktop/source/deployment/manager/dp_manager.cxx
M desktop/source/deployment/registry/dp_backend.cxx
M forms/source/runtime/formoperations.cxx
M framework/qa/complex/path_settings/PathSettingsTest.java
M jurt/test/com/sun/star/uno/AnyConverter_Test.java
M offapi/type_reference/types.rdb
M package/source/xstor/xstorage.cxx
M pyuno/source/module/pyuno_adapter.cxx
M qadevOOo/runner/util/BasicMacroTools.java
M qadevOOo/tests/java/mod/_pcr/ObjectInspectorModel.java
M qadevOOo/tests/java/mod/_remotebridge/uno/various.java
M qadevOOo/tests/java/mod/_remotebridge/various.java
M qadevOOo/tests/java/mod/_svtools/AccessibleBrowseBox.java
M qadevOOo/tests/java/mod/_sw/SwXCellRange.java
M qadevOOo/tests/java/mod/_sw/SwXDocumentIndex.java
M qadevOOo/tests/java/mod/_sw/SwXTextTable.java
M scripting/java/com/sun/star/script/framework/provider/ScriptProvider.java
M sfx2/source/doc/sfxbasemodel.cxx
M swext/mediawiki/src/com/sun/star/wiki/WikiOptionsEventHandlerImpl.java
M ucb/source/ucp/hierarchy/hierarchydata.cxx
M ucb/source/ucp/package/pkgcontent.cxx
M udkapi/com/sun/star/lang/IllegalArgumentException.idl
M wizards/com/sun/star/wizards/common/NumericalHelper.java
M wizards/com/sun/star/wizards/common/PlaceholderTextElement.java
M wizards/com/sun/star/wizards/common/PropertySetHelper.java
M wizards/com/sun/star/wizards/common/SystemDialog.java
M wizards/com/sun/star/wizards/query/Finalizer.java
M wizards/com/sun/star/wizards/report/DBColumn.java
M wizards/com/sun/star/wizards/report/ReportTextDocument.java
M wizards/com/sun/star/wizards/ui/FilterComponent.java
M wizards/com/sun/star/wizards/ui/UnoDialog.java
M wizards/com/sun/star/wizards/ui/WizardDialog.java
33 files changed, 58 insertions(+), 100 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/1145
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iad183de76ec7e0d56648084e97cdcc160b5b033d
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Michael Stahl <mstahl at redhat.com>



More information about the LibreOffice mailing list