[PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code

Thorsten Behrens thb at documentfoundation.org
Mon Oct 1 11:03:09 PDT 2012

guilherme.sft at gmail.com wrote:
> This patch removes '@author' annotation, code in comments
> and adjust some empty catches. It's cleanup patch
Hi José Guilherme,

partially pushed - I left the hunks commenting empty methods as
FIXME instead of removing them straight away unapplied. If the
method is pointless, why not remove them in one go?

I also did not apply your printStackTrace() logging calls, I think
at least some of them report on exceptions that were seemingly
previously ignored on purpose?

Stephan, or anyone else more up-to-date with contemporary java
idiom, any opinions here?

Thanks for the nice cleanup anyways! :)

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121001/160b3fa4/attachment.pgp>

More information about the LibreOffice mailing list