[PUSHED] [PATCH 2/3] fdo#51304: Remove @author annotation and commented code
sbergman at redhat.com
Tue Oct 2 01:54:00 PDT 2012
On 10/01/2012 08:03 PM, Thorsten Behrens wrote:
> I also did not apply your printStackTrace() logging calls, I think
> at least some of them report on exceptions that were seemingly
> previously ignored on purpose?
> Stephan, or anyone else more up-to-date with contemporary java
> idiom, any opinions here?
I have not much of an opinion there. The wizards code being what it is,
it is probably tedious and pointless to try and determine whether
individual exception-swallowing catch-blocks were really meant that way
or were just incompetent coding. So I'd personally be fine both with
keeping the blocks empty and with adding printStackTrace calls wholesale.
(Just one nit, System.err is the default target for printStackTrace, so
it can be omitted from calls.)
More information about the LibreOffice