[PATCH] Review corrections in basctl/.../basobj3.cxx

Jan Holesovsky kendy at suse.cz
Mon Oct 15 04:36:04 PDT 2012


Hi Ricardo,

Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +0000:

>     https://gerrit.libreoffice.org/851

Thank you a lot for the patch! :-)  Having seen it pushed, I've done a
small follow-up tweak:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ad86ef1caaa029b8c95273528afeb724fa6582d

The OUString has a convenience isEmpty() member, that is more obvious
when reading the code than the check for 0 length, would be great if you
can use that in your further patches :-)

All the best,
Kendy



More information about the LibreOffice mailing list