[PATCH] Review corrections in basctl/.../basobj3.cxx

Ricardo Montania ricardo at linuxafundo.com.br
Mon Oct 15 04:56:09 PDT 2012


Yes, no problem.

Thanks :)

On Mon, Oct 15, 2012 at 4:06 PM, Jan Holesovsky <kendy at suse.cz> wrote:

> Hi Ricardo,
>
> Ricardo Montania (via Code Review) píše v Út 09. 10. 2012 v 20:31 +0000:
>
> >     https://gerrit.libreoffice.org/851
>
> Thank you a lot for the patch! :-)  Having seen it pushed, I've done a
> small follow-up tweak:
>
>
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=5ad86ef1caaa029b8c95273528afeb724fa6582d
>
> The OUString has a convenience isEmpty() member, that is more obvious
> when reading the code than the check for 0 length, would be great if you
> can use that in your further patches :-)
>
> All the best,
> Kendy
>
>


-- 
Ricardo Montania Prado de Campos
http://www.linuxafundo.com.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121015/318ee9f3/attachment-0001.html>


More information about the LibreOffice mailing list