[REVIEW 3-6-3 2/3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

Petr Mladek pmladek at suse.cz
Fri Oct 19 07:12:24 PDT 2012


On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote:
> Hi,
> 
> On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:
> > Hey,
> > 
> > [1] fixes the problem that blank cells, like broadcaster, cells are
> > considerend non empty for the "visible" methods.
> 
> Pushed with my sign-off.

The commit in 3-6 branch is
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=23e6bac62ef6482c287bb0f55c662ac2047ebb33

It looks reasonable and works fine => +1

One more approval is needed for 3-6-3. I would prefer if it is from a
Calc expert :-)

> Correct me if I am mistaken, but shouldn't the same check be used in
> GetFirstVisDataPos and VisibleCount too?

It would make sense.

Best Regards,
Petr



More information about the LibreOffice mailing list