[PUSHED 3-6-3] fix for fdo#54552, only use non blank cells in the visible data methods in ScColumn

[Eike Rathke]

Hi,

On Friday, 2012-10-19 16:12:24 +0200, Petr Mladek wrote:
> On Fri, 2012-10-19 at 10:46 +0200, David Tardon wrote:
> > On Wed, Oct 17, 2012 at 04:28:27PM +0200, Markus Mohrhard wrote:
> > > [1] fixes the problem that blank cells, like broadcaster, cells are
> > > considerend non empty for the "visible" methods.
> > Pushed with my sign-off.
> The commit in 3-6 branch is
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6&id=23e6bac62ef6482c287bb0f55c662ac2047ebb33
> It looks reasonable and works fine => +1
> One more approval is needed for 3-6-3. I would prefer if it is from a
> Calc expert :-)

Pushed with sign-offs
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6-3&id=c38b67a171615ddc444e0fe849e10d7cada74b6a

> > Correct me if I am mistaken, but shouldn't the same check be used in
> > GetFirstVisDataPos and VisibleCount too?
> 
> It would make sense.

I think so too, and before the change of note cell handling that was the
case. However, Markus said he'd like to have testcases for that first
before changing.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD
Support the FSFE, care about Free Software! https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20121022/b90533ed/attachment.pgp>