[REVIEW 3-6] acclerate large OLE2 file reading ...
Kohei Yoshida
kohei.yoshida at gmail.com
Wed Sep 19 10:42:10 PDT 2012
Hi Michael,
On 09/19/2012 12:40 PM, Michael Meeks wrote:
>
> This reasonably trivial fix accelerates a large (private) PivotTable
> document load from 100seconds down to 20 seconds for me. It dungs out a
> chunk of code - I'm doing some more aggressive cleanup on master - to
> not hold the entire OLE2 stream in allocated memory while reading ;-)
> [ sadly we still do that while writing until 'Commit' ] - but this is
> the simpler version for 3-6.
Reviewed it and looks good to me. The only things I've changed are the
post-increment iterators to pre-increment in StgCache::Commit().
Pushed to 3-6 with my sign-off. Thanks a lot for this. :-)
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
More information about the LibreOffice
mailing list