[PATCH] Change in core[libreoffice-3-6]: No dictionaries were preselected for en_US langpack

Stephan Bergmann (via Code Review) gerrit at gerrit.libreoffice.org
Wed Sep 26 23:39:32 PDT 2012


Hi,

I have submitted a patch for review:

    https://gerrit.libreoffice.org/707

To pull it, you can do:

    git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/07/707/1

No dictionaries were preselected for en_US langpack

...as gm_Langpack_r_en_US was explicitly excluded from langs[] in
SelectLanguage, so addMatchingDictionaries was never called for it.  (This was
only evident in installation sets conaining only few langpacks, as the
"official" multi-lang installation set also contains en_GB etc., so appropriate
dictionaries were selected through those.)

Reworked the logic of chosing which langpacks to preselect (see the comment in
SelectLanguage); hope it still works as intended for the various cases (of which
the "official" multi-lang installation set is the only truly relevant one, for
now).

Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
(cherry picked from commit 8cb7464130634551fd2f043efc14f8f8f8bdf447)
---
M setup_native/source/win32/customactions/sellang/sellang.cxx
1 file changed, 71 insertions(+), 91 deletions(-)


--
To view, visit https://gerrit.libreoffice.org/707
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I31f531194c79e49c9c09e33454a7b0a82d9ff02f
Gerrit-PatchSet: 1
Gerrit-Project: core
Gerrit-Branch: libreoffice-3-6
Gerrit-Owner: Stephan Bergmann <sbergman at redhat.com>



More information about the LibreOffice mailing list