[PATCH] WIP: Convert scalc delete contents dialog to .ui

[Albert Thuswaldner]

On Tue, Apr 9, 2013 at 5:30 PM, Caolán McNamara <caolanm at redhat.com> wrote:

> On Mon, 2013-04-08 at 17:52 +0200, Albert Thuswaldner wrote:
>
> > I almost completed the conversion of the Delete Contents dialog in
> > Calc (see patch #1)
>
> What's missing from your patch is the .ui file itself, do a git
> add /path/to/that/file.ui and git commit --amend


Oops, updated the patch accordingly.


> > What I didn't manage to do was to completely kill the resource id
> > RID_SCDLG_DELCONT
> >
> > How to handle these things are not covered in your tutorial, at least
> > I could not find that...
>
> Yeah, so the removal of .src and .hrc stuff is a happy-sideeffect of
> moving to .ui files, but there are some cases where some .src contents
> remain (until e.g. we move over to gettext) and some cases where .hrc
> defines have been reused for non-resource files purposes (where the
> long-term thing will be to just move them into .hxx files)
>
> But in this particular case it so happens (common enough occurrence)
> that the remaining .hrc define can be removed anyway. See attached.


Ok, great. Thanks for the explanation, if I come across similar things in
the future I guess I can use this as a reference. For this time assume that
you commit your patch with these fixes on top of mine?


> > I am also scratching my head over the hid key in the help file, not
> > sure I got that right ( see patch #2 )
>
> Looks about right to me. What I would do in addition is to take one of
> the two duplicated "hid/.uno:Delete" bookmarks and change one to be the
> fallback toplevel dialog help e.g.
> "hid/modules/scalc/ui/deletecontents/DeleteContentsDialog


 Ok, I updated patch #2

>
> C.
>
>
Thanks for your help, much appreciated.
/Albert
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130409/b673de95/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Convert-scalc-delete-contents-dialog-to-.ui.patch
Type: application/octet-stream
Size: 29515 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130409/b673de95/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Modified-help-text-for-scalc-Delete-Contents-Dialog-.patch
Type: application/octet-stream
Size: 8533 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130409/b673de95/attachment-0003.obj>