[PUSHED][PATCH] WIP: Convert scalc delete contents dialog to .ui

Caolán McNamara caolanm at redhat.com
Wed Apr 10 06:18:57 PDT 2013


On Tue, 2013-04-09 at 22:40 +0200, Albert Thuswaldner wrote:
> On Tue, Apr 9, 2013 at 5:30 PM, Caolán McNamara <caolanm at redhat.com>
> wrote:
>         On Mon, 2013-04-08 at 17:52 +0200, Albert Thuswaldner wrote:
>         
>         > I almost completed the conversion of the Delete Contents
>         dialog in
>         > Calc (see patch #1)
>         
>         
>         What's missing from your patch is the .ui file itself, do a
>         git
>         add /path/to/that/file.ui and git commit --amend
> 
> 
> Oops, updated the patch accordingly.

Looks good, pushed. Only major thing was the title of the dialog wasn't
the original "Delete Contents" string, fix that up now.

> Ok, great. Thanks for the explanation, if I come across similar things
> in the future I guess I can use this as a reference. For this time
> assume that you commit your patch with these fixes on top of mine?

Yeah done now.

C.




More information about the LibreOffice mailing list