moving global headers into one top-level location

Michael Stahl mstahl at redhat.com
Wed Apr 10 07:37:51 PDT 2013


On 10/04/13 15:40, Bjoern Michaelsen wrote:
> Hi Eike,
> 
> On Wed, Apr 10, 2013 at 03:05:50PM +0200, Eike Rathke wrote:
>> It's not only Writer, Calc and Draw do the same with some headers, and
>> it serves a purpose, for example core or filters are not supposed to
>> access anything UI or view specific.
> 
> That is right ... and wrong. The separation e.g. between libsw and libswui is a
> Good Thing(tm). Doing so with a half-complete new concept below the module is
> wrong, and was likely only done because modules had some magic meaning in the
> old CWS/CVS voodoo making it a pain to work across them.

the problem is that the splitting of sw into 3 libraries is essentially
a hack to get better startup performance; there is not really a clean
separation there; for starters there are a lot of dependencies from core
code to SwDocShell which is in the sw/source/ui directory but not the
"swui" library.

actually the sw library links in almost 200 objects from sw/source/ui.

> If swui is a proper lib on top of sw, it should either:
> - be a toplevel module on its own

before this can happen a lot of work has to be done to clean up this
mess.  the current situation makes it at least obvious that there _is_ a
mess :)




More information about the LibreOffice mailing list