patch for postgresql driver

Lionel Elie Mamane lionel at mamane.lu
Tue Apr 16 12:28:06 PDT 2013


On Tue, Apr 16, 2013 at 03:16:25PM +0100, Wols Lists wrote:
> The attached patch is not in logerrit (I've yet to set that up), and
> there's an error in it so I'm hoping someone can help. It does a TODO in
> the file, but I can't get my argument casting right - in the original
> code, matchIgnoreAsciiCaseAsciiL wraps its argument in
> RTL_CONSTASCII_STRINGPARAM. This is defined in sal/inc/rtl/string.h and
> passes both the string and its length. So me removing it is obviously a
> mistake, but it's got some integrity checking in there and I just can't
> get it to pass that.

RTL_CONSTASCII_STRINGPARAM is a hack/optimisation specific to
compile-time constants. With your change, the string is not anymore a
compile-time constant, so just use

 equalsIgnoreAsciiCaseAscii()

-- 
Lionel


More information about the LibreOffice mailing list