What's the point in destroying whitepsace based alignment in the source?

Tor Lillqvist tml at iki.fi
Thu Apr 25 22:21:58 PDT 2013


Perhaps a good compromise would be to use a very local macro to abbreviate
the identifiers in the table, and keep the entries as one line, with
alignment of columns, but shorter:

    static SvXMLTokenMapEntry aTableRowCellAttrTokenMap[] =
    {
#define _(N,T,A) XML_NAMESPACE_##N, XML_##T, XML_TOK_TABLE_ROW_CELL_ATTR_##A

        { _(TABLE,    STYLE_NAME,                    STYLE_NAME) },
        { _(TABLE,    CONTENT_VALIDATION_NAME,
CONTENT_VALIDATION_NAME) },
        { _(TABLE,    NUMBER_ROWS_SPANNED,           SPANNED_ROWS) },
        { _(TABLE,    NUMBER_COLUMNS_SPANNED,        SPANNED_COLS) },
        { _(TABLE,    NUMBER_MATRIX_COLUMNS_SPANNED, SPANNED_MATRIX_COLS) },
        { _(TABLE,    NUMBER_MATRIX_ROWS_SPANNED,    SPANNED_MATRIX_ROWS) },
        { _(TABLE,    NUMBER_COLUMNS_REPEATED,       REPEATED) },
        { _(OFFICE,   VALUE_TYPE,                    VALUE_TYPE) },
        { _(CALC_EXT, VALUE_TYPE,                    NEW_VALUE_TYPE) },
        { _(OFFICE,   VALUE,                         VALUE) },
        { _(OFFICE,   DATE_VALUE,                    DATE_VALUE) },
        { _(OFFICE,   TIME_VALUE,                    TIME_VALUE) },
        { _(OFFICE,   STRING_VALUE,                  STRING_VALUE) },
        { _(OFFICE,   BOOLEAN_VALUE,                 BOOLEAN_VALUE) },
        { _(TABLE,    FORMULA,                       FORMULA) },
        { _(OFFICE,   CURRENCY,                      CURRENCY) },
#undef _
        XML_TOKEN_MAP_END
    };

But if not the above, I would let the original code be, i.e. revert the
change.

--tml
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130426/c032e486/attachment.html>


More information about the LibreOffice mailing list