Writer crash

[Caolán McNamara]

On Tue, 2013-08-13 at 11:36 +0200, Zolnai Tamás wrote:
> Hi Caolán,
> 
> I founnd a problem with your commit:
> 
> http://cgit.freedesktop.org/libreoffice/core/commit/?id=f41e7c704898fa0e86d6d128f5bd28f37c081e92
>
> When I try to modify a character style Writer crashes.
> After a bit debug I found that your commit changed SwDocShell::Edit()
> (in docst.cxx) method sixth parameter from sal_uInt16 to OString but
> at docst.cxx:448 this Edit method is called with 0 as sixth parameter,
> which haven't sense in the new context but interpreted as an
> rtl_String null pointer and used to call OString constructor, which
> can't handle null pointers so Writer crashes.

Yeah, that's right. I noticed that myself eventually and it should be
fixed now. Probably should have read my mail earlier and saved myself
the hassle :-)

C.