[Bug 72606] New: [EasyHack] Consistently call Unicode Win32 functions, and define UNICODE globally

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=72606

          Priority: medium
            Bug ID: 72606
                CC: jesus at softcatala.org,
                    libreoffice at lists.freedesktop.org,
                    thomas-libo at arnhold.org, tml at iki.fi
          Assignee: libreoffice-bugs at lists.freedesktop.org
           Summary: [EasyHack] Consistently call Unicode Win32 functions,
                    and define UNICODE globally
          Severity: normal
    Classification: Unclassified
                OS: Windows (All)
          Reporter: mstahl at redhat.com
          Hardware: Other
            Status: NEW
           Version: 4.3.0.0.alpha0+ Master
         Component: Libreoffice
           Product: LibreOffice

currently there are lots of places where manually macros
UNICODE and _UNICODE are defined:

http://blogs.msdn.com/b/oldnewthing/archive/2004/02/12/71851.aspx

git grep DUNICODE
git grep D_UNICODE

we should rather define that globally in solenv/gbuild/com_MSC_defs.mk.

also there is no point to ever calling the archaic so-called "ANSI"
Win32 functions (end in *A); probably it's best to call the
UCS-2 Unicode ones directly (end in *W).

corresponding string literals can be written as L"foo"

maybe once every function call is directly to a *W function
the UNICODE _UNICODE can be removed altogether, but as a first
step it's probably best to define that globally.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20131211/ef14ef9a/attachment.html>