cppcheck: Same expression in edtwin.cxx (sw module)

julien2412 serval2412 at yahoo.fr
Fri Dec 13 15:26:42 PST 2013


Hello,

Cppcheck reported this:
[sw/source/ui/docvw/edtwin.cxx:3322] ->
[sw/source/ui/docvw/edtwin.cxx:3322]: (style) Same expression on both sides
of '&&'

Indeed we have:
   3319                         // if the cursor position was corrected or
if a Fly
   3320                         // was selected in ReadOnlyMode, no word
selection.
   3321                         if ( !bValidCrsrPos ||
   3322                             (rSh.IsFrmSelected() &&
rSh.IsFrmSelected() ))
   3323                             return;

git history indicates it's like this since initial import in (2000-03-18)
Of course I could remove one rSh.IsFrmSelected() but not sure at all when
reading comment above.

Any idea?

Julien



--
View this message in context: http://nabble.documentfoundation.org/cppcheck-Same-expression-in-edtwin-cxx-sw-module-tp4088148.html
Sent from the Dev mailing list archive at Nabble.com.


More information about the LibreOffice mailing list