[SOLVED] Re: cppcheck: Same expression in chartexport.cxx (oox module)

[Julien Nabet]

On 14/12/2013 07:02, Markus Mohrhard wrote:
> Hey,
>
>
> 2013/12/13 julien2412 <serval2412 at yahoo.fr <mailto:serval2412 at yahoo.fr>>
>
>     Hello,
>
>     Cppcheck reported this:
>     [oox/source/export/chartexport.cxx:1822] ->
>     [oox/source/export/chartexport.cxx:1822]: (style) Same expression
>     on both
>     sides of '=='.
>
>     Indeed we have:
>        1822         if (aValues[i] == aValues[i])
>        1823             pFS->write( aValues[i] );
>      see
>     http://opengrok.libreoffice.org/xref/core/oox/source/export/chartexport.cxx#1790
>     (at this moment)
>
>     I thought first about == overloading but didn't find it (or missed it)
>
>     Any idea?
>
>
> Actually that code is correct. This check prevents writing out NaN 
> because NaN is not equal to itself. However I'll change it later to 
> make cppcheck happy.
Hello Markus,

Thank you for 
http://cgit.freedesktop.org/libreoffice/core/commit/?id=af7b4eca3db99a63202df285a7df7402e523ff54 
:-)

Julien
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20131214/f8a5cee0/attachment.html>