cppcheck: Same expression in chartexport.cxx (oox module)

Markus Mohrhard markus.mohrhard at googlemail.com
Fri Dec 13 22:02:38 PST 2013


Hey,


2013/12/13 julien2412 <serval2412 at yahoo.fr>

> Hello,
>
> Cppcheck reported this:
> [oox/source/export/chartexport.cxx:1822] ->
> [oox/source/export/chartexport.cxx:1822]: (style) Same expression on both
> sides of '=='.
>
> Indeed we have:
>    1822         if (aValues[i] == aValues[i])
>    1823             pFS->write( aValues[i] );
>  see
>
> http://opengrok.libreoffice.org/xref/core/oox/source/export/chartexport.cxx#1790
> (at this moment)
>
> I thought first about == overloading but didn't find it (or missed it)
>
> Any idea?
>
>
>
Actually that code is correct. This check prevents writing out NaN because
NaN is not equal to itself. However I'll change it later to make cppcheck
happy.

Regards,
Markus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20131214/66e5b485/attachment.html>


More information about the LibreOffice mailing list