Cppcheck reports 'fViewSizeX'/fViewSizeY are assigned a value never used (drawingplayer part)

[julien2412]

Hello,

Cppcheck reported this:
drawinglayer/source/primitive2d/sceneprimitive2d.cxx
196	unreadVariable	style	Variable 'fViewSizeX' is assigned a value that is
never used.
197	unreadVariable	style	Variable 'fViewSizeY' is assigned a value that is
never used.    193                     if(fReducedVisualisationFactor !=
1.0)
    194                     {
    195                         fReduceFactor *=
fReducedVisualisationFactor;
    196                         fViewSizeX *= fReducedVisualisationFactor;
    197                         fViewSizeY *= fReducedVisualisationFactor;
    198                     }
    199                 }

see
http://opengrok.libreoffice.org/xref/core/drawinglayer/source/primitive2d/sceneprimitive2d.cxx#192

Indeed, after these lines, fViewSizeX and fViewSizeY are no more used.
It's been like this since 2009-10-20 (see
http://cgit.freedesktop.org/libreoffice/core/commit/?id=2a0a3168f4354285e59dd79d4477a4199c2f773b) 
Should we remove the lines 196 and 197 or is something lacking?


Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-fViewSizeX-fViewSizeY-are-assigned-a-value-never-used-drawingplayer-part-tp4036929.html
Sent from the Dev mailing list archive at Nabble.com.