[PATCH] fdo#39446 - Bloat Removal. Removing uncallable code with cal...

Thorsten Behrens (via Code Review) gerrit at gerrit.libreoffice.org
Wed Feb 27 06:40:28 PST 2013


Hello Miklos Vajna, Tor Lillqvist,

I'd like you to reexamine a change.  Please visit

    https://gerrit.libreoffice.org/1921

to look at the new patch set (#4).

Change subject: fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher
......................................................................

fdo#39446 - Bloat Removal. Removing uncallable code with callcatcher

Removed several unused methods.

Could not remove ScVbaFormat<ooo::vba::excel::XStyle>::getAddIndent() and ScVbaFormat<ooo::vba::excel::XStyle>::setAddIndent(com::sun::star::uno::Any const&) because it breaks compilation (they are implementing pure virtual methods).
Should Test::test1Table1Page() really be removed? (test class)

Conflicts:
        unusedcode.easy

Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
---
M editeng/inc/editeng/editobj.hxx
M editeng/source/editeng/editobj.cxx
M l10ntools/inc/po.hxx
M l10ntools/source/po.cxx
M sfx2/inc/sfx2/templateabstractview.hxx
M sfx2/source/control/templateabstractview.cxx
M tools/inc/tools/line.hxx
M tools/source/generic/line.cxx
M unusedcode.easy
M vcl/inc/outfont.hxx
M vcl/inc/vcl/settings.hxx
M vcl/inc/vcl/svapp.hxx
M vcl/source/app/settings.cxx
M vcl/source/app/svapp.cxx
M vcl/source/gdi/outdev3.cxx
M writerfilter/inc/resourcemodel/WW8ResourceModel.hxx
M writerfilter/source/resourcemodel/util.cxx
M writerfilter/source/rtftok/rtfsprm.cxx
M writerfilter/source/rtftok/rtfsprm.hxx
M xmlsecurity/source/xmlsec/mscrypt/sanextension_mscryptimpl.cxx
M xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.cxx
21 files changed, 1 insertion(+), 204 deletions(-)


  git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/21/1921/4
-- 
To view, visit https://gerrit.libreoffice.org/1921
To unsubscribe, visit https://gerrit.libreoffice.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I98a761f66f28e3a82661c10a5fa1dc7e109fff2f
Gerrit-PatchSet: 4
Gerrit-Project: core
Gerrit-Branch: master
Gerrit-Owner: Jean-Noël Rouvignac <jn.rouvignac at gmail.com>
Gerrit-Reviewer: Caolán McNamara <caolanm at redhat.com>
Gerrit-Reviewer: LibreOffice gerrit bot <gerrit at libreoffice.org>
Gerrit-Reviewer: Miklos Vajna <vmiklos at suse.cz>
Gerrit-Reviewer: Thorsten Behrens <tbehrens at suse.com>
Gerrit-Reviewer: Tor Lillqvist <tml at iki.fi>



More information about the LibreOffice mailing list