[Grammar checker] Undocumented change in the API for LO 4

[Olivier R.]

Caolán McNamara wrote
> Can you supply a simple to run test-kit that could be used by someone
> else to bibisect the change ? An easy to test/run macro/script/hack that
> works in 3.6 and fails in 4.0.
> 
> C.

I bibisected myself, then I got this result:

266724b495f909e6bdc5b253b15515e7d is the first bad commit
commit 20bcb05266724b495f909e6bdc5b253b15515e7d
Author: Bjoern Michaelsen <bjoern.michaelsen at canonical.com>
Date:   Mon Dec 10 23:37:31 2012 +0000

    source-hash-f260c656da4457c5d87c161bdd43ad3023d07472
    
    commit f260c656da4457c5d87c161bdd43ad3023d07472
    Author:     Michael Stahl <mstahl at redhat.com>
    AuthorDate: Wed Oct 24 21:29:00 2012 +0200
    Commit:     Michael Stahl <mstahl at redhat.com>
    CommitDate: Wed Oct 24 21:58:26 2012 +0200
    
        vcl: uipreviewer: remove spurious "return false"
    
        Change-Id: Ie853d55f78f27a7249b8e960587c8d2bd833d1a7

:100644 100644 dd56205ffd7af4544acf767d928e0fb7c362b83d
7f44424346f71b2444850a3667fbcb6cf1ad374a M	autogen.log
:100644 100644 67df361b388bd5414a4ec178afbdeaadeb28ab12
c243de0266086f2cf364d025ede83dcb5f53fcbe M	ccache.log
:100644 100644 0cc69bf7010e61309aee815ea14e91c076f2c2a9
3d48a17ff896d1e27f4e0cd78c606bd6167043f6 M	commitmsg
:100644 100644 be0612023ec5f0a77e6afc9b23d0e3c96c66c4f4
141809713e042ff39b59de44fe7b570744c7279f M	dev-install.log
:100644 100644 ce6dd2ba02cd975b4350a4c14937a2101222a737
8b188733db3a9cf1f5810fac128a7a17acf5bf43 M	make.log
:040000 040000 ae9ac7f6e1ba77f1a9b4d8dcb3c04a4304a1c666
5a6c6e9d2d90c720a0b62142f2ce89bc713b42d7 M	op


But I have to say that I am not really sure this result can be trusted. For
each times I bibisect, LO didn't launch at the first try, only on the second
try. Three times Ubuntu froze and Compiz crashed when I closed LO.
The update system crashed while updating. The mouse pointer was frenetic.
The mouse wheel didn't work. Etc.


So if someone wants to check, here is how I proceed:
Each time I launch LO, I looked in the Extension manager if the French
grammar checker was installed. If it wasn't, I installed it in user profile
("only for me"). I closed LO and relaunched it.
Then I typed:
   Mot. Mot. Mot.
(With few spaces at the beginning.)

Normally, the first spaces must be underlined. That's for checking if the
grammar checker works properly.
But if spaces between the words "Mots." are underlined, that means the
paragraph has been split as explained in my previous messages.

Direct link to download the French grammar checker:
http://www.dicollecte.org/download/fr/Grammalecte-v0.2.5.oxt

Regards,
Olivier



--
View this message in context: http://nabble.documentfoundation.org/Grammar-checker-Undocumented-change-in-the-API-for-LO-4-tp4030639p4040542.html
Sent from the Dev mailing list archive at Nabble.com.