Cppcheck: reassignment of edt1Id because isWin2000() has been removed (fpicker module)

julien2412 serval2412 at yahoo.fr
Thu Jun 13 11:03:39 PDT 2013


Cppcheck reported this:
<error file="fpicker/source/win32/filepicker/WinFileOpenImpl.cxx" line="994"
id="redundantAssignment" severity="style" msg="Variable 'edt1Id' is
reassigned a value before the old one has been used."/>

    988         sal_Int32 edt1Id = edt1;
    990         // under W2k the there is a combobox instead
    991         // of an edit field for the file name edit field
    992         // the control id of this box is cmb13 and not
    993         // edt1 as before so we must use this id
    994         edt1Id = cmb13;

Since we don't support anymore isWin2000 (removed by
b30f91c58419e90a789f79a1391b13f2064997ab, 2011/07/20) , according to the
comment shouldn't it be:
  sal_Int32 edt1Id = edt1;
instead ?


View this message in context: http://nabble.documentfoundation.org/Cppcheck-reassignment-of-edt1Id-because-isWin2000-has-been-removed-fpicker-module-tp4061342.html
Sent from the Dev mailing list archive at Nabble.com.

More information about the LibreOffice mailing list