About coverity 705732 (svdundo.cxx from svx module)

[Thorsten Behrens]

Julien Nabet wrote:
> I noticed several things:
> 1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks
> must be changed
> 2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems
> there's a leak
>
Yeps.

> 3) why pObj->ActionChanged() and  ImpShowPageOfThisObject() are always
> called ?
> 
I would not suggest relying on that - this code has some serious 15+
years of bugfix sedimentation behind it. If you've played some
multiple hours with your fix in, and understood the code flow, go for
it - otherwise, don't take chances. ;)

Cheers,

-- Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20130312/f87c0234/attachment.pgp>