About coverity 705732 (svdundo.cxx from svx module)

Caolán McNamara caolanm at redhat.com
Wed Mar 13 03:51:50 PDT 2013


On Tue, 2013-03-12 at 13:43 -0700, julien2412 wrote:
> I noticed several things:
> 1) we could replace "if (pText1)" by "if (pNewText)". Of course if blocks
> must be changed
> 2) if pText1 corresponds to a new OutlinerParaObject and !pText, it seems
> there's a leak
> 3) why pObj->ActionChanged() and  ImpShowPageOfThisObject() are always
> called ?
> 
> So I thought about this patch:

Yeah, looks right to me FWIW.

C.



More information about the LibreOffice mailing list