[Libreoffice-commits] core.git: Branch 'libreoffice-4-0' - sc/CppunitTest_sc_subsequent_export_test.mk sc/qa sc/source xmloff/inc

[Lubos Lunak]

On Thursday 28 of March 2013, Noel Power wrote:
>  sc/CppunitTest_sc_subsequent_export_test.mk |    1
>  sc/qa/unit/data/ods/rotflipshapes.ods       |binary
>  sc/qa/unit/helper/qahelper.hxx              |    5 +
>  sc/qa/unit/subsequent_export-test.cxx       |   78
> ++++++++++++++++++++++++++++ sc/source/filter/xml/xmlexprt.cxx           | 
>  32 +++++++++++
>  xmloff/inc/xmloff/shapeexport.hxx           |    2
>  6 files changed, 117 insertions(+), 1 deletion(-)
>
> New commits:
> commit 2058479575e4a3e003eb1917c4f0947db9145623
> Author: Noel Power <noel.power at suse.com>
> Date:   Tue Mar 26 18:21:27 2013 +0000
>
>     hacky fix for export of cell anchored flipped custom shapes (fdo#62448)
>
>     On export it is assumed the translate co-ords are the same as
>     the topleft of the logical rectangle. What rectangle to use
>     at any given time, the transformations and the fact that
>     different object types seems to handle rotation etc. in their
>     own way leaves me confused as to what the correct fix might be.
>     This fix though won't make things worse ( afaict )
>
>     Change-Id: I6c704f9aebd650d530ebc32fbe73c251719494fe
>     Reviewed-on: https://gerrit.libreoffice.org/3064
>     Tested-by: Petr Mladek <pmladek at suse.cz>
>     Reviewed-by: Petr Mladek <pmladek at suse.cz>

 I have reverted this commit, as it fails on at least two 4-0 tinderboxes 
(Clang and Win-x86_6). I also couldn't find anything like this in master. 
Please check the commit.

-- 
 Lubos Lunak
 l.lunak at suse.cz