[Libreoffice-commits] core.git: formula/source: get rid of unnecessary warning

Winfried Donkers W.Donkers at dci-electronics.nl
Mon Sep 16 05:03:20 PDT 2013


Hi Eike,

Just got back from holidays, sorry I have kept you waiting.

> >>-    DBG_ASSERT( 0 < eOp && sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of range");
> >>-    if (0 < eOp && sal_uInt16(eOp) < mnSymbols)
> >>+    DBG_ASSERT( sal_uInt16(eOp) < mnSymbols, "OpCodeMap::putOpCode: OpCode out of range");
> >>+    if (sal_uInt16(eOp) < mnSymbols)

> I never saw that and I'm usually on a dbgutil build.
> May it be that it was caused by another change you did?

It occurs with the changes as in https://gerrit.libreoffice.org/#/c/5691/ (your review on that one is highly appreciated), there may be a connection.

Winfried


More information about the LibreOffice mailing list