[Libreoffice-commits] core.git: 7 commits - chart2/source extensions/source hwpfilter/source l10ntools/source sal/osl unoidl/source

[Stephan Bergmann]

On 08/04/2014 11:47 PM, Norbert Thiebaud wrote:
> On Mon, Aug 4, 2014 at 8:38 PM, Michael Stahl <mstahl at redhat.com> wrote:
>> a rule such as "if the condition is a single line, put the brace on the
>> same line, if it is multiple lines, put the brace on a separate line"
>> can still be called consistent  :)
>
> I guess.. but the point of a formatting rule is easy to read and above
> all _visually consistent_.
> There is apparently debate about the readability of the different
> braces scheme.. but surely there can't be any argument that a mix of
> both is the worse of both world.

I must confess that I happily live by that rule, as it IMO separates the 
individual parts without introducing too much visual clutter,

   if (cccccccccccccc) {
       bbbbbbbbbbbbbbbbbbbbbbbbbbbb
       bbbbbbbbbbbbbbbbbbbbbbbbb
       bbbbbbbbbbbbbbbbbbbbbbbbbbb
   }
   if (cccccccccccccccccccccccccc
       ccccccccccccccccccccccc
       ccccccccccccccccccccccccc)
   {
       bbbbbbbbbbbbbbbbbbbbbbbbbbbb
       bbbbbbbbbbbbbbbbbbbbbbbbb
       bbbbbbbbbbbbbbbbbbbbbbbbbbb
   }

I agree that this involves a certain degree of subtlety, but that is IMO 
not much different from how much subtlety needs to go into traditional 
typography, for the benefit of the reader.

Anyway, somehow any discussion about formatting quickly diverts into 
bikeshedding ("this is /so/ lucid!" "no it isn't!" "yes it is!").  So 
all I would like to repeat is my humble plea to refrain from 
reformatting commits, for the sake of a less cluttered git history.

Stephan