About fdo#70185 starmath: unit test writing

Markus Mohrhard markus.mohrhard at googlemail.com
Mon Dec 8 22:13:37 PST 2014


so the attched version of the patch gets you past that problem. Now the
test fails actually in parsing which you should debug and check if there is
something missing or if there is a setup problem.

The problem that I fixed is that because you passed the filter version as
current it was trying to handle the file as a ODF file. I think there are
still a few wrong filter flags but that would need some more debugging and
checking which are used during a normal import.


On Tue, Dec 9, 2014 at 5:58 AM, Markus Mohrhard <
markus.mohrhard at googlemail.com> wrote:

> On Tue, Dec 9, 2014 at 5:43 AM, Takeshi Abe <tabe at fixedpoint.jp> wrote:
>> Hi Markus,
>> Thank you for quick reply.
>> On Tue, 9 Dec 2014 04:47:16 +0100, Markus Mohrhard <
>> markus.mohrhard at googlemail.com> wrote:
>> (snip)
>> > So this might be just a missing component file in the makefile. Could
>> you
>> > please attach your work in progress patch so we can easily reproduce the
>> > problem and help you?
>> That's the attached one with the previous mail.
> Sorry, I missed that. I'll have a look at it.
>> Or, do you mean any other essential piece of new cppunit tests are missing
>> in the patch?
>> Cheers,
>> -- Takeshi Abe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141209/de5e1c7f/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-prototype-of-unit-test-for-importing-a-MathML-file.patch
Type: text/x-diff
Size: 7036 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141209/de5e1c7f/attachment.patch>

More information about the LibreOffice mailing list