Failing unit test in Mac OS X Yosemite 10.10.1

Miklos Vajna vmiklos at collabora.co.uk
Mon Dec 15 00:27:24 PST 2014


Hi,

On Fri, Dec 12, 2014 at 06:52:03PM -0500, Kohei Yoshida <kohei.yoshida at collabora.com> wrote:
> > Test name: testCropPixel::Import_Export_Import
> > assertion failed
> > - Expression: getXPath(pXmlDoc, "//a:srcRect", "l").toInt32() <= 21856
> ...
> > 
> > My Mac (Retina 13") gives the value 22452, but I'm not able to tell
> > which value is "valid", or on which Mac with retina the other value
> > was produced. Does anybody else use OS X Yosemite here?
> 
> I do, and I'm getting exactly the same thing.  Every time.

Strange, as on tinderbox complains. Anyway, the problem is not specific
to Writer, it affects Calc and Impress as well, see commit
e16b01a9e4e111b1267c4eec1f5d168e5c2b8e53 (it's the shared drawingML
export code).

> Usually, each import export test has an associated file you can open,
> then by comparing the content of the file and the code in the test, one
> can perhaps make a best effort guess of what the test expects, and what
> expectation is incorrect and/or whether there is a real bug in it...

Each time I write such an assertion, I add a comment about what was the
old/wrong value, so in case you get 1999 instead of 2000, you have a
chance to judge if the old rounding error is back or in fact the 1999 vs
2000 is not a big difference in this case. In this case, it says "the
image become invisible", so hopefully you can easily just manually load
and save the document and verify if on your machine the image becomes
invisible in Word or not. :-)

Thanks,

Miklos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141215/ddd5924a/attachment.sig>


More information about the LibreOffice mailing list