Cppcheck reports Same expression on both sides of '&&' (sc module)

[julien2412]

Hello,

Cppcheck reported this:
sc/source/core/opencl/op_statistical.cxx
3221	duplicateExpression	style	Same expression on both sides of '&&'.
3233	duplicateExpression	style	Same expression on both sides of '&&'.
3245	duplicateExpression	style	Same expression on both sides of '&&'.
3305	duplicateExpression	style	Same expression on both sides of '&&'.
3317	duplicateExpression	style	Same expression on both sides of '&&'.

eg:
   3220         else if ((pDVR->IsStartFixed() && !pDVR->IsEndFixed())
   3221             &&(pDVR->IsStartFixed() && !pDVR->IsEndFixed()))

(see
http://opengrok.libreoffice.org/xref/core/sc/source/core/opencl/op_statistical.cxx#3220)

Should the second line use pDVR1 (like some other parts), should the second
line be removed each time, or something else should be done?

Julien



--
View this message in context: http://nabble.documentfoundation.org/Cppcheck-reports-Same-expression-on-both-sides-of-sc-module-tp4103436.html
Sent from the Dev mailing list archive at Nabble.com.