[Bug 43157] Clean up OSL_ASSERT, DBG_ASSERT, etc.
bugzilla-daemon at freedesktop.org
bugzilla-daemon at freedesktop.org
Thu May 15 16:12:33 PDT 2014
https://bugs.freedesktop.org/show_bug.cgi?id=43157
Mukhiddin Yusupov <yusupmuk at fel.cvut.cz> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #25 from Mukhiddin Yusupov <yusupmuk at fel.cvut.cz> ---
(In reply to comment #0)
> The assertion/logging functionality from osl/diagnose.h (OSL_TRACE,
> OSL_ASSERT, OSL_ENSURE, OSL_FAIL) and tools/debug.hxx (DBG_ASSERTWARNING,
> DBG_ASSERT, DBG_BF_ASSERT, DBG_WARNING, DBG_WARNING1--5, DBG_WARNINGFILE,
> DBG_ERRORFILE) is obsolete and needs to be cleaned up:
>
> * To assert invariants of the code (that can only be violated if there are
> programming errors) use standard C/C++ assert.
>
> * To log warnings about unusual events (that the code nevertheless needs to
> handle in some way, like malformed input or I/O failures), use the
> SAL_WARN... macros from sal/log.h.
>
> * To log other information useful for debugging, use the SAL_INFO... macros.
>
> See
> <https://wiki.documentfoundation.org/Development#Assertions_and_Logging>,
> the mail thread at
> <http://lists.freedesktop.org/archives/libreoffice/2011-November/020864.
> html>, and the documentation in the sal/log.h header for further information.
In spite of the fact that many people uploaded commits I found that in some
files these obsolete assertions/logging. I am going to change as many of these
files as I can.
--
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20140515/de55ef7a/attachment.html>
More information about the LibreOffice
mailing list