build failure, clock_gettime undefined, linking libavmedialo.so

[David Tardon]

Hi,

On Fri, May 16, 2014 at 03:19:21PM +0100, Tamas Zolnai wrote:
>  
> On Friday, May 16, 2014 15:00 BST, Terrence Enger <tenger at iseries-guru.com> wrote: 
>  
> > My build of commit 48eccfb, fetched around 2014-05-16 00:57 UTC, is
> > failing with messages:
> > 
> >     [build LNK] Library/libavmedialo.so
> >     /home/terry/lo_hacking/git/libo2/workdir/LinkTarget/StaticLibrary/libcollada2gltf.a(GLTF-Open3DGC.o): In function `o3dgc::Timer::Tic()':
> >     /home/terry/lo_hacking/git/libo2/workdir/UnpackedTarball/collada2gltf/dependencies/o3dgc/src/o3dgc_common_lib/inc/o3dgcTimer.h:115: undefined reference to `clock_gettime'
> I google it and find that:
> http://stackoverflow.com/questions/2418157/ubuntu-linux-c-error-undefined-reference-to-clock-gettime-and-clock-settim
> It suggests to link -lrt library.
> So you can try to add these lines:
> ifeq ($(OS),LINUX)
> $(eval $(call gb_Library_add_libs,collada2gltf,\
> 	-lrt \
> ))
> endif
> to the external/collada2gltf/StaticLibrary_collada2gltf.mk file.

This will not work. The extra library is needed at the place(s) where
collada2gltf.a is _used_. The attached patch should do that.

D.
-------------- next part --------------
>From 8e1800c467ab44edea5f2e0055bbbfc8253d2ff7 Mon Sep 17 00:00:00 2001
From: David Tardon <dtardon at redhat.com>
Date: Sun, 18 May 2014 12:42:37 +0200
Subject: [PATCH] fix linking with collada2gltf lib

Change-Id: I3628c41803a2a0432354c8fcb9e090b53ebef4f1
---
 RepositoryExternal.mk | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 6e2d19b..6c9b787 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -3148,6 +3148,12 @@ $(call gb_LinkTarget_set_include,$(1),\
 $(call gb_LinkTarget_use_static_libraries,$(1),\
 	collada2gltf \
 )
+
+ifeq ($(OS),LINUX)
+$(call gb_LinkTarget_add_libs,$(1),\
+	-lrt \
+)
+endif
 endef
 
 endif
-- 
1.9.0