[SOLVED] Re: Strange part in connectivity/source/drivers/jdbc/tools.cxx

[Stephan Bergmann]

On 05/30/2014 09:27 AM, Stephan Bergmann wrote:
> On 05/29/2014 12:48 PM, Julien Nabet wrote:
>> On 29/05/2014 12:31, Tor Lillqvist wrote:
>>> Check the semantics of OUString::compareToAscii(). It returns zero on
>>> equality, like strcmp()
>> Should have begun with this, thank you both of you.
>> And to avoid asking the same question a second time, I added a comment
>> by quoting Tor,
>> see
>> http://cgit.freedesktop.org/libreoffice/core/commit/?id=74393875bcad5890a9510c7e8fd8643f63e081c2
>>
>
> ...would arguably be even better to instead make the implicit conversion
> to bool explicit via
>
>    pBegin->Name.compareToAscii( "JavaDriverClass" ) != 0 ...

...or, of course, even better yet,

   pBegin->Name != "JavaDriverClass" ...

Stephan