[SOLVED] Re: Strange part in connectivity/source/drivers/jdbc/tools.cxx

[Lionel Elie Mamane]

On Fri, May 30, 2014 at 10:58:33AM +0200, Stephan Bergmann wrote:
> On 05/30/2014 09:27 AM, Stephan Bergmann wrote:
>> On 05/29/2014 12:48 PM, Julien Nabet wrote:
>>> On 29/05/2014 12:31, Tor Lillqvist wrote:

>>>> Check the semantics of OUString::compareToAscii(). It returns zero on
>>>> equality, like strcmp()

>>> Should have begun with this, thank you both of you.

>>> And to avoid asking the same question a second time, I added a
>>> comment by quoting Tor,

>> ...would arguably be even better to instead make the implicit conversion
>> to bool explicit via

>>   pBegin->Name.compareToAscii( "JavaDriverClass" ) != 0 ...

> ...or, of course, even better yet,

>   pBegin->Name != "JavaDriverClass" ...

Yes, Julien, this one is IMHO worth doing. It makes the code that much
more readable :)

-- 
Lionel