dead code in sc/source/filter/excel/xeformula.cxx?

Eike Rathke erack at redhat.com
Fri Nov 28 06:49:17 PST 2014


Hi Winfried,

On Friday, 2014-11-28 12:08:21 +0100, Winfried Donkers wrote:

> Now adding arguments to functions when exporting to Excel has been restored with commit 4feaf96f50fa89eccb4e7a638220099e9a8482f1, I suspect there is dead code in sc/source/filter/excel/xeformula.cxx.
> How do I find out what is really dead and can be removed and what isn't?

Are you referring
XclExpFmlaCompImpl::PrepareFunction()
XclExpFmlaCompImpl::FinishFunction()
XclExpFmlaCompImpl::AppendDefaultParam()
XclExpFmlaCompImpl::AppendTrailingParam()
?

These are used for the BIFF export. 

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key ID: 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20141128/5a8b6407/attachment.sig>


More information about the LibreOffice mailing list