dead code in sc/source/filter/excel/xeformula.cxx?

Winfried Donkers W.Donkers at dci-electronics.nl
Sun Nov 30 23:01:29 PST 2014


Hi Eike,

>Are you referring
>XclExpFmlaCompImpl::PrepareFunction()
>XclExpFmlaCompImpl::FinishFunction()
>XclExpFmlaCompImpl::AppendDefaultParam()
>XclExpFmlaCompImpl::AppendTrailingParam()
>?
>These are used for the BIFF export. 

Yes, e.g. in XclExpFmlaCompImpl::AppendDefaultParam() there is a line
  if (GetOutput() == EXC_OUTPUT_XML_2007), which IMHO will never be true
and there are some
 if (GetOutput() != EXC_OUTPUT_XML_2007), which IMHO will never be false.
Possibly there is more.

Winfried


More information about the LibreOffice mailing list