[Bug 90290] reduce some copy&paste code in ucalc

[bugzilla-daemon at bugs.documentfoundation.org]

https://bugs.documentfoundation.org/show_bug.cgi?id=90290

--- Comment #14 from Markus Mohrhard <markus.mohrhard at googlemail.com> ---
(In reply to David Tardon from comment #13)
> (In reply to Markus Mohrhard from comment #0)
> > ucalc is one of the mail calc tests and is split between many files in
> > sc/qa/unit
> > 
> > This task is about improving the existing pattern around checkFormula in
> > sc/qa/unit/ucalc_formula.cxx
> > 
> > A typical piece of code looks like this:
> > 
> >     if (!checkFormula(*m_pDoc, aPos, "SUM(A3:A7)"))
> >         CPPUNIT_FAIL("Wrong formula!");
> > 
> > This should be changed to something like:
> > 
> > checkFormula(*m_pDoc, aPos, "SUM(A3:A7)", "Wrong formula!");
> 
> What is wrong with
> 
> CPPUNIT_ASSERT_MESSAGE("Wrong formula!", checkFormula(*m_pDoc, aPos,
> "SUM(A3:A7)"))
> 
> ? That would address Kohei's concerns without any necessary changes to
> cppunit.

I already talked to Kohei and he seems to be fine with changing it.

The reason that I wanted to move to CPPUNIT_ASSERT_EQUAL is that it will print
both strings in case of a failure which is extremely helpful for debugging.

I think if necessary we can implement Tor's suggestion in LibreOffice. There is
no need to do it in CPPUNIT as there should be already support for an own
asserter message.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150413/aa2d7995/attachment.html>