Bug 88457: urls fails to copy&paste in Calc - Asking for directions and code pointers

[Eike Rathke]

Hi Matteo,

On Sunday, 2015-02-08 22:32:56 -0500, Matteo Campanelli wrote:

> I was looking at this recent bug:
> https://bugs.documentfoundation.org/show_bug.cgi?id=88457&redirected_from=fdo
> 
> The bug's behavior is basically: urls from a cell cannot be copied and
> pasted in another cell in Calc. IOW nothing happens after pasting (however
> special paste seems to work).

Must be a different bug number though..

> It seems the bug was introduced with one of my commits last Summer, namely:
> http://cgit.freedesktop.org/libreoffice/core/commit/?h=feature/gsoc14-draw-text-background-color&id=c2580813426a58cd2ab22efacec9d28423201562
> 
> This small commit simply registers a new text item, EE_CHAR_BKGCOLOR, to
> deal with the background color of text.
> Does anyone have a guess of how this could affect this behavior on Calc?
> 
> It seems that urls in Calc are automatically filled with a grey background,
> so I wonder whether this conflicts with the handling of background color by
> EE_CHAR_BKGCOLOR.

Which introduced a shift of some WhichIDs.

> Does anyone have some pointers to where this happens in Calc's code (i.e.
> where urls are assigned a background)?

My guess is it happens when the feature field should be copied and
something isn't prepared for the shift in WhichIDs. It looks like the
field already isn't copied to the target EditEngine, as editing a cell
uses an EditEngine, maybe the clipboard transfer lacks the attribute due
to the shift. The field is already missing when the target cell is still
in edit mode.

Also places in Calc where loops until EE_CHAR_END are executed or
EE_FEATURE_FIELD is handled could be worth an investigation.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GPG key "ID" 0x65632D3A - 2265 D7F3 A7B0 95CC 3918  630B 6A6C D5B7 6563 2D3A
Better use 64-bit 0x6A6CD5B765632D3A here is why: https://evil32.com/
Care about Free Software, support the FSFE https://fsfe.org/support/?erack
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150211/d4ee78e8/attachment.sig>