sc/source/core/data/dociter.cxx: really suspicious use of ! in condition

Matteo Casalin matteo.casalin at yahoo.com
Wed Feb 18 06:57:43 PST 2015


Hi Stephan,
    thanks for looking into this.
That code was already there - could it be that for some reason the plugin was used for that file but did not detect that instance?

Kind regards
Matteo

On Wed, 18 Feb 2015 12:53:34 +0100
Stephan Bergmann <sbergman at redhat.com> wrote:

> On 02/18/2015 11:51 AM, Matteo Casalin wrote:
> >      while looking at http://cgit.freedesktop.org/libreoffice/core/commit/?id=a5ab0e3a8b1cb7c06072229e1c4d956eb81fa002 I noticed a really suspicious use of ! on the same line that was modified:
> >
> > && ! nMinNextEnd < nRow
> 
> mistakes like this (which appears to already have been fixed) are 
> automatically found by loplugin:implicitboolconversion
> _______________________________________________
> LibreOffice mailing list
> LibreOffice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/libreoffice


More information about the LibreOffice mailing list