tubes/source/conference.cxx:251:79: error: 'OSL_ENSURE' was not declared in this scope

Stephan Bergmann sbergman at redhat.com
Thu Jan 8 01:33:40 PST 2015


On 01/07/2015 11:37 AM, Bjoern Michaelsen wrote:
> Personal opinion: The double bookkeeping of log areas is bad, and people ignore
> it because its a direct violation of DRY. IMHO if that plugin is active, it
> should just add the missing log areas. Whoever is caring about consistency in
> the log areas then simply needs to look at that file once in a while and tweak
> existing log areas into a consistent state. Consistency is not something that
> can be achieved by forcing over 200 people to do edits to one file(*), it needs to
> be maintained by 1-2 people with a good context on what is there and what the
> customs are.

Not sure about the double-bookkeeping and DRY-ness arguments.  (For 
amusement, there's even a real, printed book out there, touting itself 
as a guidebook on contemporary C, that recommends using string literals 
instead of enums; you can't make that up.)

Regarding the remainder, my perspective is somewhat more relaxed:  Log 
area inconsistencies become a problem when one wants to filter on them. 
  But at least as long as the logging is only enabled in (developers') 
debug builds, a developer who wants to do filtering and is bitten by 
some inconsistency can just clean up the relevant code.  So as long as 
the proliferation of log areas does not grow too much out of control, I 
think we can happily live with the status quo.


More information about the LibreOffice mailing list