Font combo box sample text issue

[Chris Sherlock]

Hi all, 

I’ve been looking at some things in the LO codebase, and I noticed that we aren’t always displaying sample text in the font combobox (used in sidebar, writer toolbar and calc toolbar). 

I have actually winkled down the issue to an issue in the code in FontNameBox::UserDraw

The code assumes that it needs to help fonts that can’t render their own Latin-based font family names, then it needs to provide sample text - but it does a very specific lookup for the particular font to get the sample text. I guess that’s OK, but frankly I don’t want to update the code every time a font like this comes out - I don’t think this is scalable, and besides you have to update LO to get this minor feature (and I think it unlikely developers will want to anyway). 

Anyhow, I’ve put a brief code commit to gerrit, the reason I haven’t pushed it is because it appears that some Latin fonts are show the sample text as “AB”. Other than this, the patch is working like a charm. 

Can anyone see why the text is coming up for these latin based fonts as “AB”? The goal for these fonts is that we don’t *need* to show any sample text. 

Bug report filed here:

https://bugs.freedesktop.org/show_bug.cgi?id=88484 <https://bugs.freedesktop.org/show_bug.cgi?id=88484>

Gerrit review is here:

https://gerrit.libreoffice.org/#/c/13952/ <https://gerrit.libreoffice.org/#/c/13952/>

Any pointers or help would be gratefully accepted :-) I suppose it’s very minor in the grand scheme of things, but I quite like the feature and I think making our software friendly for other languages and cultures is worthwhile!

Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/libreoffice/attachments/20150117/40781ad5/attachment.html>